GEODE-9896: Bump ace to 7.0.6 #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix building on macos monterry Authored-by: M. Oleske <michael@oleske.engineer>
|
failing lgtm is due to geode 1.14.2 no longer being available. this is fixed #912 |
jake-at-work
approved these changes
Jan 28, 2022
|
Windows 2016 Visual Studio 2017 failed because tar was missing. I'll leave it to @pdxcodemonkey or @mikemartell to decide if this PR should be reran through CI before merging |
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
- fix building on macos monterry Authored-by: M. Oleske <michael@oleske.engineer>
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
- fix building on macos monterry Authored-by: M. Oleske <michael@oleske.engineer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: M. Oleske michael@oleske.engineer
Let me know if this should be part of GEODE-9896 Upgrade Dependencies
This may conflict with #899