GEODE-10074: Remove ACE remainings #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaussianrecurrence
force-pushed
the
feature/GEODE-10074
branch
from
6d39594
to
bb1c910
Compare
- Removed all the ACE includes along the repository - Removed ACE from CMake project. - Removed ACE dependency. - There were a couple of files in which ACE's strcmp was used. So, its usage was replaced to to std::string::operator== - Removed non-necessary ACE's getcwd calls.
gaussianrecurrence
force-pushed
the
feature/GEODE-10074
branch
from
bb1c910
to
a072c8f
Compare
jake-at-work
requested changes
Feb 23, 2022
jake-at-work
approved these changes
Apr 13, 2022
|
@gaussianrecurrence please rebase to resolve conflicts, and I will merge ASAP. Thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, its usage was replaced to to std::string::operator==