GEODE-10076. Align String serialization with Java client #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertogpz
force-pushed
the
feature/GEODE-10076
branch
3 times, most recently
from
999cf6e
to
0f95f40
Compare
albertogpz
force-pushed
the
feature/GEODE-10076
branch
2 times, most recently
from
a71b6f0
to
3d13b96
Compare
albertogpz
force-pushed
the
feature/GEODE-10076
branch
from
3d13b96
to
9df71d4
Compare
albertogpz
force-pushed
the
feature/GEODE-10076
branch
from
9df71d4
to
20b7dcd
Compare
albertogpz
force-pushed
the
feature/GEODE-10076
branch
from
20b7dcd
to
8ca51af
Compare
gaussianrecurrence
approved these changes
Jul 8, 2022
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 2, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by using unicode hexcode codepoint characters, rather than the actual codepoint.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 4, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 11, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 11, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 16, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Aug 16, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
albertogpz
pushed a commit
that referenced
this pull request
Aug 17, 2022
- After merging #973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
albertogpz
pushed a commit
to Nordix/geode-native
that referenced
this pull request
Nov 8, 2022
- After merging apache#973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Geode C++ native client library serializes strings of PdxSerializable objects with DSCode CacheableString.
Nevertheless, the Java client, in order to serialize Strings, it analyzes them and different DSCodes are assigned depending on the contents (only ASCII vs not only ASCII chars) and length. In the native client, it's always set to CacheableString, whenever for example in the case of an ASCII string should be CacheableASCIIString.
This can provoke that two objects with the same contents created one by the native client and the other by the Java classes return false when compared with the equals method.
The writeString() method of the DataOutput() class of the Geode C++ native client library has been aligned with its counterpart in the Java library so that the serialization is the same in both cases.