GEODE-10371: C++ client: Improve dispersion on connections expiration #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertogpz
force-pushed
the
feature/GEODE-10371
branch
from
1f4f5a8
to
760e50e
Compare
albertogpz
force-pushed
the
feature/GEODE-10371
branch
from
760e50e
to
e2ebf32
Compare
| return random; | ||
| std::random_device rd; | ||
| std::default_random_engine generator(rd()); | ||
| std::uniform_int_distribution<int> distribution(-9, 9); |
There was a problem hiding this comment.
It'd be good to add a couple of constants to add some semantic meaning to the distribution limits
| std::unique_ptr<TcrConnectionTest>(new TcrConnectionTest( | ||
| static_cast<const TcrConnectionManager>(nullptr))); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a suggestion for a change to this case or maybe for another case, but given the goal of this change is to ensure the variance is evenly distributed along the connections created within a close period of time, I'd suggest instead of comparing with the first value, I'd rather sample the distribution and check no bucket in the sample has more than x times (i.e double) the expected amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.