GEODE-10396: Avoid endpoint closure upon exception #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently whenever a server function is executed on a region with no filter, if an IllegalStateException wrapped within a FunctionException is thrown inside the server fuction body, then the endpoint's connections are closed, given the client considers the endpoint is failing. - In order to solve this, now it's checked if the exception is wrapped into a FunctionException before triggering the endpoint disconnection mechanism. - A new IT has been added to verify the behavior.
|
I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter, if an IllegalStateException wrapped within a
FunctionException is thrown inside the server fuction body, then
the endpoint's connections are closed, given the client considers the
endpoint is failing.
into a FunctionException before triggering the endpoint disconnection
mechanism.