GEODE-10402: Fix FunctionException handling #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed handling for FunctionException. - Added InternalFunctionInvocationTargetException and replaced GF_FUNCTION_EXCEPTION by GF_INTERNAL_FUNCTION_INVOCATION_TARGET_EXCEPTION, so function exceptions are properly handled. - Code modified to adapt to the above changes.
- Actually added handling for FunctionException exception in ThinClientRegion. - Removed InternalFunctionInvocationTargetException as part of the public API since this is part of the internal Java API. - Added a new IT to verify that FunctionExceptions thrown by the user are actually thrown in the native library as FunctionException's.
- Fixed clang-tidy warnings. - Fixed format on one of the Java classes for testing.
gaussianrecurrence
added a commit
to Nordix/geode-native
that referenced
this pull request
Oct 3, 2022
* GEODE-10402: Fix FunctionException handling - Fixed handling for FunctionException. - Added InternalFunctionInvocationTargetException and replaced GF_FUNCTION_EXCEPTION by GF_INTERNAL_FUNCTION_INVOCATION_TARGET_EXCEPTION, so function exceptions are properly handled. - Code modified to adapt to the above changes. * GEODE-10402: Revision 1 - Actually added handling for FunctionException exception in ThinClientRegion. - Removed InternalFunctionInvocationTargetException as part of the public API since this is part of the internal Java API. - Added a new IT to verify that FunctionExceptions thrown by the user are actually thrown in the native library as FunctionException's. * GEODE-10402: Format code * GEODE-10402: Revision 2 - Fixed clang-tidy warnings. - Fixed format on one of the Java classes for testing.
albertogpz
pushed a commit
to Nordix/geode-native
that referenced
this pull request
Nov 8, 2022
* GEODE-10402: Fix FunctionException handling - Fixed handling for FunctionException. - Added InternalFunctionInvocationTargetException and replaced GF_FUNCTION_EXCEPTION by GF_INTERNAL_FUNCTION_INVOCATION_TARGET_EXCEPTION, so function exceptions are properly handled. - Code modified to adapt to the above changes. * GEODE-10402: Revision 1 - Actually added handling for FunctionException exception in ThinClientRegion. - Removed InternalFunctionInvocationTargetException as part of the public API since this is part of the internal Java API. - Added a new IT to verify that FunctionExceptions thrown by the user are actually thrown in the native library as FunctionException's. * GEODE-10402: Format code * GEODE-10402: Revision 2 - Fixed clang-tidy warnings. - Fixed format on one of the Java classes for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GF_FUNCTION_EXCEPTION by
GF_INTERNAL_FUNCTION_INVOCATION_TARGET_EXCEPTION, so function
exceptions are properly handled.