GEODE-3306: Add unit tests

Modified existing `testCacheXmlParserWithSimplePool()` to be able to
close the created cache, otherwise there will be an
IllegalStateException thrown about an "incomplete shutdown of a previous
cache".

geode-core/build.gradle

@@ -142,6 +142,8 @@ dependencies {
   testCompile 'com.pholser:junit-quickcheck-core:' + project.'junit-quickcheck.version'
   testCompile 'com.pholser:junit-quickcheck-generators:' + project.'junit-quickcheck.version'
   testCompile 'com.pholser:junit-quickcheck-guava:' + project.'junit-quickcheck.version'
+
+  testRuntime 'xerces:xercesImpl:' + project.'xercesImpl.version'
 }
 
 def generatedResources = "$buildDir/generated-resources/main"

geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java

@@ -23,6 +23,8 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheFactory;
 import org.apache.geode.distributed.internal.DM;
 import org.apache.geode.distributed.internal.InternalDistributedSystem;
 import org.apache.geode.test.junit.categories.UnitTest;
@@ -113,8 +115,23 @@ public void testCacheXmlParserWithSimplePool() {
     when(dm.getSystem()).thenReturn(system);
     InternalDistributedSystem.connect(nonDefault);
 
-    CacheXmlParser.parse(getClass()
-        .getResourceAsStream("CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml"));
+    Cache cache = new CacheFactory()
+        .set("cache-xml-file", "CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml")
+        .create(InternalDistributedSystem.connect(nonDefault));
+    cache.close();
+  }
+
+  /**
+   * Test that {@link CacheXmlParser} can parse the test cache.xml file, using the Apache Xerces XML
+   * parser.
+   * 
+   * @since Geode 1.3
+   */
+  @Test
+  public void testCacheXmlParserWithSimplePoolXerces() {
+    System.setProperty("javax.xml.parsers.SAXParserFactory",
+        "org.apache.xerces.jaxp.SAXParserFactoryImpl");
+    testCacheXmlParserWithSimplePool();
   }
 
   /**
@@ -137,6 +154,19 @@ public void testDTDFallbackWithNonEnglishLocal() {
     }
   }
 
+  /**
+   * Test that {@link CacheXmlParser} falls back to DTD parsing when locale language is not English,
+   * using the Apache Xerces XML parser.
+   * 
+   * @since Geode 1.3
+   */
+  @Test
+  public void testDTDFallbackWithNonEnglishLocalXerces() {
+    System.setProperty("javax.xml.parsers.SAXParserFactory",
+        "org.apache.xerces.jaxp.SAXParserFactoryImpl");
+    testDTDFallbackWithNonEnglishLocal();
+  }
+
   /**
    * Get access to {@link CacheXmlParser} protected methods and fields.
    * 

gradle/dependency-versions.properties

@@ -99,3 +99,4 @@ tomcat6.version = 6.0.37
 tomcat7.version = 7.0.73
 tomcat8.version = 8.5.9
 commons-validator.version = 1.6
+xercesImpl.version = 2.11.0