Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-4112: Replaced FunctionAdapter with Function #1185

Merged
merged 1 commit into from Dec 20, 2017

Conversation

nabarunnag
Copy link
Contributor

@nabarunnag nabarunnag commented Dec 19, 2017

* This commit is specific to geode-lucene only
* Before making any changes serialVersionUID was generated for the files which were to be modified.
* The FunctionAdapters were replaced with Function

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

	* This commit is specific to geode-lucene only
	* Before making any changes serialVersionUID was generated for the files which were to be modified.
	* The FunctionAdapters were replaced with Function
Copy link
Contributor

@jhuynh1 jhuynh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We might want to add a note to show that java serialization isn't really used for these functions but that the serialVersionUID was added anyways.

@nabarunnag nabarunnag merged commit eec297f into apache:develop Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants