GEODE-4299: refactor eviction #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serializable, Declarable, and Clonable.
instead of that class plus AbstractRegion and EvictionAttributesImpl
UnsupportOperationException. It now just returns 0 if it is a HeapLRU.
and the bucket is not recursively closed
code currently does not compile
dschneider-pivotal
requested review from
nreich,
kirklund,
agingade,
pivotal-eshu and
lgallinat
nreich
reviewed
Jan 17, 2018
| @@ -14,816 +14,15 @@ | |||
| */ | |||
| package org.apache.geode.internal.cache; | |||
There was a problem hiding this comment.
Maybe we should just go ahead and remove the class now: if we remove it later, we will have the same issue of possible merge conflicts caused by the change.
| public interface EvictableRegion { | ||
| EvictionAttributes getEvictionAttributes(); | ||
|
|
||
| boolean getOffHeap(); |
There was a problem hiding this comment.
this was a preexisting method on the implementation classes that I just added to this new interface. So for this PR I don't plan on renaming it. I think it comes from the external RegionAttributes interface so renaming it could break existing user's code.
nreich
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EvictionController classes are no longer Serializable nor Cloneable. These internal classes used to be external and needed to be these things in the past because they were stored in the configuration. But they no longer are so these interfaces were removed for clarity.
The EvictionController classes are no longer responsible for creating InternalEvictionStatistics. Instead the other entities it depends on are passed in to its constructor.
The only class with an EvictionController instance is now VMLRURegionMap which makes the code easier to understand and reduces the number of inter-module dependencies.
renamed internalSetMaximum to setMaximum on EvictionAttributesImpl
AbstractBucketRegionQueue no longer uses EvictionStatistics to notify itself that it removed some objects from the queue. So it no longer needs to access all the EvictionStatistics.
AbstractLRURegionMap has been moved to VMLRURegionMap
Casts to AbstractLRURegionMap have been removed by added additional methods to RegionMap.
new EvictableRegion interface make clear the things a region implementation needs to do/provide for the eviction implementation
EvictionAttributesMutator is now implemented by the dedicated class EvictionAttributesMutatorImpl
close and clear on RegionMap now take a BucketRegion parameter so that the eviction classes do not need to keep track of the BucketRegion.
EvictionList no longer does some of the things it did before that should have been the responsibility of the EvictionController. Now the EvictionList is given the EvictionController it should defer to. The EvictionListBuilder has been simplified since EvictionList now only needs a controller.
The eviction classes that track statistics have been refactored to be clearer. Now the EvictionStats interface is implemented by classes that provide vsd type stats. The EvictionCounters interface is implemented by a class that wraps EvictionStats and provides atomics for some of them.