GEODE-4300 Server logs warning message when protobuf client closes socket #1335
Conversation
…cket Inhibit logging of a warning message on IOExceptions if the socket is closed.
| @@ -77,7 +77,9 @@ protected void doOneMessage() { | |||
| setClientDisconnectedException(e); | |||
| logger.debug("Encountered EOF while processing message: {}", e); | |||
| } catch (IOException | IncompatibleVersionException e) { | |||
| logger.warn(e); | |||
| if (!socket.isClosed()) { // GEODE-4300, IOException may be thrown thrown on EOF | |||
There was a problem hiding this comment.
Do we need to put GEODE-4300 in the code since the commit comment also includes it?
There was a problem hiding this comment.
We were actually complemented on doing this when VMWare audited the GemFire source base, but I understand where you're coming from.
|
@upthewaterspout Is your proposal to add a "goodbye" message to the protocol that the client sends to the server to indicate that it is safe to close the socket? |
|
@PivotalSarge - Or maybe have different logic for the protobuf server connection? I'm not really sure if this warning is useful for the old client, but it might be there to help people notice that their clients are crashing. |
|
I've added GEODE-4401 to consider adding a CloseConnection message and I've pushed & closed this PR. |
Inhibit logging of a warning message on IOExceptions if the socket is
closed.
@upthewaterspout @WireBaron @PivotalSarge @galen-pivotal
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
[na] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.