GEODE-4379: Move RemoteOutputStreamServer from gfsh to the manager #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeppe-pivotal
requested review from
sboorlagadda,
PurelyApplied,
jinmeiliao and
pdxrunner
jdeppe-pivotal
force-pushed
the
feature/GEODE-4379
branch
from
f18f215
to
b2b4081
Compare
|
It sounds like this is making a pretty big change in the system behavior. I am surprised that there doesn't seem to be a test that's verifying that change. |
- This flips the deployment of jars from a pull (by server) to a push (from gfsh).
…loader$RemoteFile
jdeppe-pivotal
force-pushed
the
feature/GEODE-4379
branch
from
1f3faae
to
a7f39ca
Compare
|
@pivotal-amurmann The existing tests for jar deployment from gfsh cover this change. |
|
precheckin is green |
jinmeiliao
approved these changes
Jan 26, 2018
nonbinaryprogrammer
pushed a commit
to nonbinaryprogrammer/geode
that referenced
this pull request
Dec 24, 2018
…pache#1341) * GEODE-4379: Move RemoteOutputStreamServer from gfsh to the manager - This flips the deployment of jars from a pull (by server) to a push (from gfsh). * GEODE-4379: Update sanctioned-geode-core-serializables.txt for FileUploader$RemoteFile (cherry picked from commit af25a80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gfsh).
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.