Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-4375: Fix problem that an exception occurs when transaction from CacheServer via Pool #1363

Merged
merged 2 commits into from Jan 31, 2018
Merged

GEODE-4375: Fix problem that an exception occurs when transaction from CacheServer via Pool #1363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6cef4e
GEODE-4375: Fix problem that an exception occurs when transaction from
masaki-yamakawa Jan 30, 2018
11f7938
GEODE-4375: Fix problem that an exception occurs when transaction from
masaki-yamakawa Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
View file
Open in desktop
Expand Up @@ -1384,7 +1384,11 @@ public void fromData(DataInput in) throws IOException, ClassNotFoundException {
for (int i = 0; i < size; i++) {
FarSideEntryOp entryOp = new FarSideEntryOp();
// shadowkey is not being sent to clients
entryOp.fromData(in, largeModCount, !this.msg.getDM().isLoner());
LocalRegion region = getRegionByPath(msg.getDM(),
parentRegionPath != null ? parentRegionPath : regionPath);
boolean readShadowKey =
(region != null ? (region.getPoolName() == null) : !msg.getDM().isLoner());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines with their ternaries are so dense with logic, that I wonder if it might be worthwhile to split this out into a private method and break this out more into variables and maybe even a if/else statement instead of the ternary to make this easier to follow.

entryOp.fromData(in, largeModCount, readShadowKey);
if (entryOp.versionTag != null && this.memberId != null) {
entryOp.versionTag.setMemberID(this.memberId);
}
Expand Down