GEODE-3800: Replace BackupManager with BackupService #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agingade
requested review from
nreich,
kirklund,
pivotal-eshu,
lgallinat and
dschneider-pivotal
nreich
approved these changes
Jan 31, 2018
| @@ -192,7 +192,7 @@ boolean isCancelled() { | |||
| return isCancelled; | |||
| } | |||
|
|
|||
| void waitForBackup() { | |||
| void waitTillBackupFilesAreCopiedToTemporaryLocation() { | |||
There was a problem hiding this comment.
The name suggests too much of the internal implementation. Maybe something like: "waitUntilDestroysAllowed" or "waitForFileCopyCompletion", something like that?
There was a problem hiding this comment.
It was done only on BackupTask...The reason was to help the reader to know when the wait will terminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each backup request, instead of creating BackupManager, the request is passed to a BackupService.