GEODE-4439 Refactor HandShake.java #1374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created ServerSideHandshake and ServerSideHandshakeImpl for servers. Created ClientSideHandshake and ClientSideHandshakeImpl for clients. Message encryption/decryption is now in an Encryptor interface. HandShake is renamed Handshake.
PivotalSarge
approved these changes
Feb 1, 2018
| import org.apache.geode.security.Authenticator; | ||
| import org.apache.geode.security.GemFireSecurityException; | ||
|
|
||
| public abstract class Handshake { |
galen-pivotal
requested review from
upthewaterspout,
PivotalSarge,
WireBaron and
galen-pivotal
PivotalSarge
approved these changes
Feb 2, 2018
WireBaron
approved these changes
Feb 2, 2018
| protected HandShake getHandShake() { | ||
| return handShake; | ||
| protected byte[] encryptBytes(byte[] messageBytes) throws Exception { | ||
| return handshake.getEncryptor().encryptBytes(messageBytes); |
There was a problem hiding this comment.
Is there any risk of handshake not being set when this (or decryptBytes) is called?
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Looks like there are several places in this file that have a few extra newlines.
|
commit c1b21c0 (HEAD -> develop, origin/develop) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created ServerSideHandshake and ServerSideHandshakeImpl for servers.
Created ClientSideHandshake and ClientSideHandshakeImpl for clients.
Message encryption/decryption is now in an Encryptor interface.
-- opened a new ticket to track that client/server diffie-hellman handshake has been broken since 2008
HandShake is renamed Handshake.
@PivotalSarge @WireBaron @upthewaterspout @galen-pivotal
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.