GEODE-4487: Remove singleton calls from offheap package #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data. Instead it just tells you it is pdx and the type number.
dschneider-pivotal
requested review from
nreich,
kirklund,
agingade,
pivotal-eshu and
lgallinat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test was using the singletons just to confirm the cache had been shutdown. It was easy to change that test to not confirm the singleton was null but to instead ask if the test's cache was closed.
The other test was testing DataType which is product code that is only used by tests to inspect what is stored in offheap memory. The test was mocking the singleton methods because the product DataType was using the singleton to decode a serialized PDX. I changed DataType to just do less decoding of pdx. Now it will just say it was a pdx and give you the type number.