New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-4353: Deprecating security-client-dhalgo #1383
GEODE-4353: Deprecating security-client-dhalgo #1383
Conversation
Deprecating this property and removing description from the manual.
Modified table cell format for consistency with neighboring entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. (I made a format change to the properties table.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change: docstrings don't match up with the settings in DistributionConfig.
@@ -2057,6 +2057,8 @@ | |||
|
|||
/** | |||
* The name of the Diffie-Hellman symmetric algorithm "security-client-dhalgo" property. | |||
* | |||
* @deprecated since Geode 1.5. Use SSL instead. See {@link #SSL_ENABLED_COMPONENTS_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You put this on the security-udp-dhalgo property because the docstring is wrong. That should be deprecated as well but at least the comment should be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I fixed it.
Deprecating this property and removing description from the manual.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.