GEODE-3643: Add function execution on specific member #1409
Conversation
This implements function execution onMember and onMembers. Members are identified by their names - see ConfigurationProperties.NAME.
bschuchardt
requested review from
upthewaterspout,
WireBaron,
PivotalSarge and
galen-pivotal
| @Override | ||
| public DistributedMember getMemberWithName(String name) { | ||
| for (DistributedMember id : members.values()) { | ||
| if (id.getName() != null && id.getName().equals(name)) { |
There was a problem hiding this comment.
Could Objects.equals() be of use here?
There was a problem hiding this comment.
I second Sarge's suggestion.
| } | ||
|
|
||
| @Test | ||
| public void noopTest() { |
| @@ -59,7 +61,7 @@ | |||
| import org.apache.geode.test.junit.categories.IntegrationTest; | |||
|
|
|||
| @Category(IntegrationTest.class) | |||
| public class FunctionExecutionIntegrationTest { | |||
| public class ExecutFunctionOnRegionIntegrationTest { | |||
| @Override | ||
| public DistributedMember getMemberWithName(String name) { | ||
| for (DistributedMember id : members.values()) { | ||
| if (id.getName() != null && id.getName().equals(name)) { |
There was a problem hiding this comment.
I second Sarge's suggestion.
|
|
||
| try { | ||
| Execution execution; | ||
| if (memberIds.size() == 1) { |
There was a problem hiding this comment.
Why do we need to check this rather than just passing an iterator with one member?
There was a problem hiding this comment.
I don't understand this comment. The FunctionService API has two onMember methods, neither of which takes an iterator as an argument.
There was a problem hiding this comment.
I actually tried making the OnRegion integration test parameterized so it could test both onRegion and OnMember but there were too many places that required specific request/response objects.
There was a problem hiding this comment.
Oh, I'd misread the call. I think we can do the same call to onMembers with a Set of size 1. Under the hood, it ends up resolving to the same call, and should have to for sanity.
| @@ -59,7 +61,7 @@ | |||
| import org.apache.geode.test.junit.categories.IntegrationTest; | |||
|
|
|||
| @Category(IntegrationTest.class) | |||
| public class FunctionExecutionIntegrationTest { | |||
| public class ExecutFunctionOnRegionIntegrationTest { | |||
There was a problem hiding this comment.
This was copied from the other integration test, though X-)
| final String functionID = request.getFunctionID(); | ||
| ProtocolStringList memberNameList = request.getMemberNameList(); | ||
|
|
||
| final Function<?> function = FunctionService.getFunction(functionID); |
There was a problem hiding this comment.
Can we avoid copying and pasting code from the on region function here? Maybe a utility or something like that?
There was a problem hiding this comment.
@upthewaterspout, the code looks very similar but the request and response objects are different classes, making it difficult to extract much of anything into a helper class. If you have some ideas maybe we could work on that together.
fixups from review comments
fixing a dumb test failure
This implements function execution onMember and onMembers. Members are
identified by their names - see ConfigurationProperties.NAME.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.