Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-4403: Remove ProtobufErrorCode #1432

Merged
merged 1 commit into from Feb 14, 2018

Conversation

galen-pivotal
Copy link
Contributor

as it's a duplicate of BasicTypes.ErrorCode

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • [not really applicable] Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Copy link
Contributor

@PivotalSarge PivotalSarge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, if you want the super bonus extra credit, you could change the Failure.of() signature to take an ErrorCode and string and then build the appropriate response rather than having all of this builder code out there everywhere return an error.

as it's a duplicate of BasicTypes.ErrorCode
@galen-pivotal
Copy link
Contributor Author

Rebased on develop, will merge if tests pass.

@galen-pivotal galen-pivotal merged commit 10a9124 into apache:develop Feb 14, 2018
@galen-pivotal galen-pivotal deleted the feature/GEODE-4403 branch February 14, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants