Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-4745: Stat check asserts modified #1510

Merged
merged 1 commit into from Feb 28, 2018

Conversation

nabarunnag
Copy link
Contributor

@nabarunnag nabarunnag commented Feb 26, 2018

* The assert check for the lucene commit checks have been modified to address the fact that it is not deterministic
* The reindex thread may be faster than the puts being done by the test hence the number of commits may different depending on whether the puts were faster or the reindexing thread.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

	* The assert check for the lucene commit checks have been modified to address the fact that it is not deterministic
	* The reindex thread may be faster than the puts being done by the test hence the number of commits may different depending on whether the puts were faster or the reindexing thread.
Copy link
Contributor

@jhuynh1 jhuynh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense based on how it's designed today

@nabarunnag nabarunnag merged commit 0e36a99 into apache:develop Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants