GEODE-4833: JdbcWriter and JdbcAsyncWriter may fail to write null fields to database #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to actually get the data type from JDBC.
dschneider-pivotal
requested review from
nreich,
kirklund,
agingade,
pivotal-eshu and
lgallinat
instance is not serialized with PDX
kirklund
reviewed
Mar 19, 2018
|
|
||
| private TableMetaDataManager tableMetaDataManager; | ||
| private Connection connection; | ||
| DatabaseMetaData databaseMetaData; |
There was a problem hiding this comment.
I'd make all of these fields private.
agingade
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.