GEODE-4893: rework reloading the cluster configuration on existing va… #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmeiliao
requested review from
jdeppe-pivotal,
sboorlagadda,
PurelyApplied and
pdxrunner
…nilla servers. * adding acceptance test to verify existing server is not shut down * instead of closing/recreate the cache instance, reload the cluster configuration xml/properties/jars.
jinmeiliao
force-pushed
the
recreateCache
branch
from
568a021
to
20e8de7
Compare
PurelyApplied
requested changes
Mar 26, 2018
| "import cluster-configuration --zip-file-name=" + clusterConfigZipPath, "sleep --time=1", | ||
| "list members").execute(gfsh); | ||
|
|
||
| list_members.getOutputText() |
There was a problem hiding this comment.
I suspect these are meant to be assertions?
|
|
||
| list_members.getOutputText() | ||
| .contains("Successfully applied the imported cluster configuration on server"); | ||
| list_members.getOutputText().contains("serverNotShutDown |"); |
There was a problem hiding this comment.
This will match on the start server command since the script contains many commands. Split the start-up, the configuration import, and the list members into separate gfsh scripts.
|
After speaking with Jinmei, I went ahead and made the test corrections on her behalf. |
PurelyApplied
approved these changes
Mar 26, 2018
pdxrunner
approved these changes
Mar 26, 2018
pdxrunner
approved these changes
Mar 26, 2018
|
Precheckin green, excepting a failure due to GEODE-4980. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nilla servers.
Need review on reloading the cluster configuration. Though initial set of tests show everything is in order. Not sure if all the elements in the cache.xml gets properly applied.