New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-4991: do no use hard coded quotes #1728
Merged
agingade
merged 6 commits into
apache:develop
from
dschneider-pivotal:feature/GEODE-4991
Apr 10, 2018
Merged
GEODE-4991: do no use hard coded quotes #1728
agingade
merged 6 commits into
apache:develop
from
dschneider-pivotal:feature/GEODE-4991
Apr 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when quoting identifiers. If this method returns null, an empty string, or a string with all spaces then no quoting will be done.
dschneider-pivotal
requested review from
nreich,
kirklund,
agingade,
pivotal-eshu and
lgallinat
April 3, 2018 21:02
nreich
approved these changes
Apr 3, 2018
kirklund
approved these changes
Apr 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
agingade
reviewed
Apr 4, 2018
|
||
String createSelectQueryString(String tableName, List<ColumnValue> columnList) { | ||
assert columnList.size() == 1; | ||
ColumnValue keyCV = columnList.get(0); | ||
assert keyCV.isKey(); | ||
return "SELECT * FROM \"" + tableName + "\" WHERE \"" + keyCV.getColumnName() + "\" = ?"; | ||
return "SELECT * FROM " + quote + tableName + quote + " WHERE " + quote + keyCV.getColumnName() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add a helper method to quote around table/column name:
String getQuotedTableColumnName(name) {
return quote + name + quote;
}
agingade
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.sql.DatabaseMetaData.getIdentifierQuoteString is now used when quoting identifiers.
If this method returns null,
an empty string,
or a string with all spaces then no quoting will be done.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.