GEODE-5355: Remove BackupUtil and BackupDataStoreHelper #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirklund
commented
Jul 2, 2018
•
kirklund
commented
- Rename *Operation classes to *Step in backup package
- Introduce new BackupOperation as internal API for launching backup
- Convert static code in backup package to instance code
- Move locking for backup to BackupLockService
* Rename *Operation classes to *Step * Introduce new BackupOperation as internal API for launching backup
kirklund
requested review from
agingade,
pivotal-eshu,
lgallinat and
dschneider-pivotal
| @@ -32,7 +32,7 @@ | |||
| * of the backup, the members will suspend bucket destroys to make sure buckets aren't missed during | |||
| * the backup. | |||
| */ | |||
| public class FlushToDiskOperation { | |||
| public class FlushToDiskStep { | |||
There was a problem hiding this comment.
why doesn't this extend BackupStep?
There was a problem hiding this comment.
I'm not sure but it never extended BackupStep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.