Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-5363: Moves all non-unit tests into specific isolated source sets. #2126

Merged
merged 58 commits into from Jul 17, 2018
Merged

GEODE-5363: Moves all non-unit tests into specific isolated source sets. #2126

merged 58 commits into from Jul 17, 2018

Conversation

jake-at-work
Copy link
Contributor

  • Creates integrationTest source set.
  • Creates distributedTest source set.
  • Creates acceptanceTest source set.
  • Creates uiTest source set.
  • Removes old categories.

@upthewaterspout
Copy link
Contributor

I still want to review the gradle changes, but one thing we should probably do with this PR is just diff the tests that got run as part of the above checks with the develop pipeline at the same revision. If we're not missing any tests I think we're good.

@jake-at-work
Copy link
Contributor Author

@upthewaterspout I have tried to do that along the way. What I found was there were tests that overlapped primary categories or had the wrong primary category (integration when they really were distributed). On top of that people keep adding or fixing tests so the counts and lists of tests is a moving target. The number of tests are within a few of previous runs in each category. Some more, some less, some the same.

@jake-at-work
Copy link
Contributor Author

The 1 failure in the concourse-ci/DistributedTest CI passes normally. It looks like the CI is having resource issues.

@jake-at-work
Copy link
Contributor Author

Test numbers are still lining up compared to those based on the old categories.

upthewaterspout
upthewaterspout approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@upthewaterspout upthewaterspout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle changes look good to me.

@jake-at-work jake-at-work force-pushed the feature/GEODE-5363 branch 3 times, most recently from 393c8ff to 299be62 Compare July 16, 2018 20:34
@jake-at-work
Copy link
Contributor Author

Opened ticket for flaky test in CI distributedTest https://issues.apache.org/jira/browse/GEODE-5440.

@rhoughton-pivot
Copy link
Member

Looks good. Passes build and test on my end

@jake-at-work
GEODE-5363: Creates integration test source set.
63935bc
@jake-at-work
GEODE-5363: Move integration tests to new directory.
1d5aabf
@jake-at-work
GEODE-5363: Creates distributed test source set.
7567533
@jake-at-work
GEODE-5363: Moves distributed tests into new source set.
7509c13
@jake-at-work
GEODE-5363: Moves distributed tests into new source set.
dccbd5b
@jake-at-work
GEODE-5363: Moves distributed tests into new source set.
440c637
@jake-at-work
GEODE-5363: Moves distributed tests into new source set.
b487efe
@jake-at-work
GEODE-5363: Moves distributed tests into new source set.
c5754b9
@jake-at-work
GEODE-5363: Moves performance tests into new source set.
bdf896c
@jake-at-work
GEODE-5363: Moves pulse tests into new source sets.
11647e6
@jake-at-work
GEODE-5363: Moves geode-junit tests into new source sets.
7345b4a
@jake-at-work
GEODE-5363: Moves geode-wan tests into new source sets.
ac3085b
@jake-at-work
GEODE-5363: Moves geode-cq tests into new source sets.
3674f34
@jake-at-work
GEODE-5363: Moves geode-lucene tests into new source sets.
27c57b7
@jake-at-work
GEODE-5363: Moves geode-assembly tests into new source sets.
09f9f16
@jake-at-work
GEODE-5363: Moves geode-modules tests into new source sets.
46b001a
@jake-at-work
GEODE-5363: Fixes tomcat tests.
c58ae97
@jake-at-work
GEODE-5363: Ignore inner classes.
da694f9
@jake-at-work
GEODE-5363: Cleanup
fe345e1
@jake-at-work
GEODE-5363: Fixes tomcat tests.
4482af4
@jake-at-work
GEODE-5363: Allow parallel tests.
05ca7d9
@jake-at-work
GEODE-5363: Rebase cleanup.
8758c44
@jake-at-work
GEODE-5363: Run distributed tests from new sourceSet
7b56685
@jake-at-work
GEODE-5363: Removes DistributedTest category.
f8d5f2d
@jake-at-work
GEODE-5363: Run acceptanceTest from new source set.
c78ec0a
@jake-at-work
GEODE-5363: Remove acceptanceTest category
f84c693
@jake-at-work
GEODE-5363: Remove parallel changes.
1bc9e1f
@jake-at-work
GEODE-5363: Remove category filter.
5393e55
@jake-at-work
GEODE-5363: Run uiTests from new source set.
3670bc2
@jake-at-work
GEODE-5363: Rebase cleanup
25b99c0
@jake-at-work
GEODE-5363: Removes latent acceptance test category.
bdc812f
@jake-at-work
GEODE-5363: Reclassify acceptance tests as integration and distributed.
55ab4e0
@jake-at-work
GEODE-5363: Rebase cleanup.
de152f7
@jake-at-work
GEODE-5363: Don't run inner class tests.
2867200
@jake-at-work
GEODE-5363: Fixes SSL test.
5892668
@jake-at-work
GEODE-5363: Fixes acceptance test.
caa683d
@jake-at-work
GEODE-5363: Rebase cleanup.
eef8406
@jake-at-work
GEODE-5363: Make test sourcesets build when compiling all other sources.
d3f07e9
@jake-at-work
GEODE-5363: Cleanup rebase
bf4ecd5
@jake-at-work
GEODE-5363: Cleanup rebase
ddbf1af
@jake-at-work
GEODE-5363: Cleanup rebase
d0c51f3
@jake-at-work jake-at-work merged commit cb202f2 into apache:develop Jul 17, 2018
aditya87 pushed a commit to aditya87/geode that referenced this pull request Jul 26, 2018
@jake-at-work
GEODE-5363: Moves all non-unit tests into specific isolated source se…
10e6f49 
…ts. (apache#2126)

* Creates integrationTest source set.
* Creates distributedTest source set.
* Creates acceptanceTest source set.
* Creates uiTest source set.
* Removes old categories.
@jake-at-work jake-at-work deleted the feature/GEODE-5363 branch May 1, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upthewaterspout upthewaterspout upthewaterspout approved these changes

@kirklund kirklund Awaiting requested review from kirklund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jake-at-work @upthewaterspout @rhoughton-pivot