GEODE-3530: refactor ListClientCommandDUnitTest #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jinmei Liao <jiliao@pivotal.io>
Co-authored-by: Jinmei Liao <jiliao@pivotal.io>
mcmellawatt
approved these changes
Jul 12, 2018
| locator = cluster.startLocatorVM(0); | ||
| int locatorPort = locator.getPort(); | ||
| server1 = cluster.startServerVM(1, | ||
| r -> r.withRegion(RegionShortcut.REPLICATE, "stocks").withConnectionToLocator(locatorPort)); |
There was a problem hiding this comment.
"stocks" could be extracted into a final String local variable since it is used throughout these tests. Makes it easier to change the name of the region down the line if we need to (one place to change)
| int server2port = server2.getPort(); | ||
| Properties client1props = new Properties(); | ||
| client1props.setProperty("name", "client-1"); | ||
| client1 = cluster.startClientVM(3, client1props, cf -> { |
There was a problem hiding this comment.
I'm a fan of extracting ID numbers like 3 here into a local variable i.e. client1ID, so when we use it later its obvious what we are working with next time we use it (shutting down the client).
upthewaterspout
approved these changes
Jul 12, 2018
geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/ListClientCommandDUnitTest.java
|
Precheckin fails for |
aditya87
pushed a commit
to aditya87/geode
that referenced
this pull request
Jul 26, 2018
Co-authored-by: Jinmei Liao <jiliao@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jinmei Liao jiliao@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.