GEODE-5292: Flushing to disk in test before introducing spy in test #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retending to."" This reverts commit e4bd46d.
This test was modifying the concurrent region map to introduce a spy, but there was a concurrent thread overflowing entries to disk at the same time. An interaction between the spy and the async flush caused the ref count to go to 0, and the test to fail before it even got to the point of clearing the region. Flushing the disk before introducing the spy.
dschneider-pivotal
approved these changes
Jul 13, 2018
aditya87
pushed a commit
to aditya87/geode
that referenced
this pull request
Jul 26, 2018
…pache#2140) This test was modifying the concurrent region map to introduce a spy, but there was a concurrent thread overflowing entries to disk at the same time. An interaction between the spy and the async flush caused the ref count to go to 0, and the test to fail before it even got to the point of clearing the region. Flushing the disk before introducing the spy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was modifying the concurrent region map to introduce a spy,
but there was a concurrent thread overflowing entries to disk at the
same time. An interaction between the spy and the async flush caused the
ref count to go to 0, and the test to fail before it even got to the
point of clearing the region.
Flushing the disk before introducing the spy.
@balesh2 @FSOUTHERLAND