GEODE-5212: Fix TestUtil to return path #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeppe-pivotal
approved these changes
Aug 8, 2018
| @@ -63,7 +63,7 @@ private static String getResourcePath(String name, URL resource) { | |||
| File tmpFile = File.createTempFile(filename, null); | |||
| tmpFile.deleteOnExit(); | |||
| FileUtils.copyURLToFile(resource, tmpFile); | |||
| return compatibleWithWindows(tmpFile.getAbsolutePath()); | |||
| return tmpFile.getAbsolutePath(); | |||
There was a problem hiding this comment.
Just FYI, I found that Paths.get(URI) will return the correct path on both Windows and Unix (but throws an exception if the resource is jar:file:/... instead of file:/...). But in this piece of code it feels like there would need to be a bunch of nested exception blocks which would make it pretty ugly. However since this is just test code the method could also just throw an Exception. The upside would be that the compatibleWithWindows method would not be necessary any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a classpath resource is looked up the path
retrieved from the resource URI can be null in which
case it creates a file from copying the resource. This
temp file path is already a good one to be returned.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.