Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5652: use unlimited ThreadPoolExecutor in ExecutorServiceRule #2395

Merged
merged 1 commit into from Aug 30, 2018

Conversation

kirklund
Copy link
Contributor

@kirklund kirklund commented Aug 28, 2018

This changes the ExecutorServiceRule to use an unlimited ThreadPoolExecutor.

Improve or fixup a couple tests that use the ExecutorServiceRule:

  • PartitionedRegionCreationDUnitTest
  • DLockServiceLeakTest
  • InterruptDiskJUnitTest (major overhaul)

This PR depends on PR #2405 (GEODE-5662: improve timeouts in ExecutorServiceRuleTest) which deleted two flaky tests from ExecutorServiceRuleTest because the tests were primarily testing ExecutorService instead of the rule itself.

@kirklund
Copy link
Contributor Author

StressNewTest failed a couple times:

org.apache.geode.test.junit.rules.ExecutorServiceRuleTest > singleThreadedByDefault FAILED
    org.junit.ComparisonFailure: expected:<[1]> but was:<[2]>
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.apache.geode.test.junit.rules.ExecutorServiceRuleTest.singleThreadedByDefault(ExecutorServiceRuleTest.java:122)

@kirklund kirklund changed the title GEODE-5652: use newCachedThreadPool by default in ExecutorServiceRule GEODE-5652: use unlimited ThreadPoolExecutor in ExecutorServiceRule Aug 29, 2018
@kirklund kirklund force-pushed the GEODE-5652-ExecutorServiceRule branch from 37c35a5 to cb32789 Compare August 29, 2018 23:06
@kirklund kirklund force-pushed the GEODE-5652-ExecutorServiceRule branch from cb32789 to 0a4b3c0 Compare August 29, 2018 23:12
@kirklund kirklund merged commit 52a6e42 into apache:develop Aug 30, 2018
@kirklund kirklund deleted the GEODE-5652-ExecutorServiceRule branch August 30, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants