GEODE-5688 Create task to generate all sources for better IDE behavior

[rhoughton-pivot]

Use ./gradle generate to create the sources from both protobuf and
ANTLR, then refresh the IDE sources and build as normal.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

[metatype]

Why not just run the existing gradle tasks to generate the files?

[rhoughton-pivot]

Can you tell me those names without looking? On Sep 5, 2018 16:29, "Anthony Baker" <notifications@github.com> wrote: Why not just run the existing gradle tasks to generate the files? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2422 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aer30txE-l_Ij4FwH4mGuAwfHHgT0Rqaks5uYF5sgaJpZM4WZ3We> .

[jake-at-work]

@metatype there are multiple targets in different projects to execute. Having a meta-task that these, and any new ones, attach to makes it easy to document.

1. Clone
2. ./gradlew magic
3. Import into IJ
   Where magic does everything minimally necessary to import into IJ or Eclipse.

[jake-at-work]

Why do we need this dependency and all the others added after this line?

[rhoughton-pivot]

assemble is the lifecycle task most closely aligned with this task as a dependency, then we use mustRunAfter to ensure that our generate tasks happen first within this project in all cases.

[jake-at-work]

I don’t understand why we need to do that though. They already happen before assemble by design. We should only need to add a pseudo target to encourage them to run outside of that normal behavior for quick project generation.

[rhoughton-pivot]

@pivotal-jbarrett I'll remove the offending lines. Look for incoming commit...

[metatype]

@pivotal-jbarrett gradle build works right (or event dev-build)? I don't get why we need gradle generate. Seems like unnecessary overhead to maintain in our build scripts. Every custom task we write is one more thing to maintain across gradle versions :-)

[jake-at-work]

@metatype I don't see it as anything more than devBuild, which was added to ease the pain of build when all you want to do is develop. Well if you want to develop in an IDE why do I need to run build or devBuild to get 1% of the tasks completed that are necessary to work from the IDE?

[jake-at-work]

Why does this need to be done in afterEvaluate?

[rhoughton-pivot]

Turns out it does not. I had both generation tasks using identical formatting for consistency, but it is not needed here. I have removed the block for this dependency change.

[PurelyApplied]

I like the idea of this minimal task, but I somewhat agree with Anthony that having to remember to run ./gradlew generate is little better than having to remember to run ./gradlew dev.

Is there a way to hook this into the idea module (and for Eclipse if necessary)? It's been a huge pain point to get OQLLexerToken.java and protobuf issues when just trying to run a test, and while this makes that quick to fix, it would be ideal if there weren't the break in workflow in the first place.

[jake-at-work]

There is not a way to teach IDEA to generate or run arbitrary tasks. You can tell it to use gradle for all tasks or for none.

[jake-at-work]

Is this afterEvaluate really necessary too?

[rhoughton-pivot]

Yes.

…

On Fri, Sep 14, 2018 at 2:02 PM Jacob Barrett ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In geode-protobuf-messages/build.gradle <#2422 (comment)>: > @@ -61,3 +61,7 @@ task zip(type: Zip) { } assemble.dependsOn 'zip' + +afterEvaluate { Is this afterEvaluate really necessary too? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2422 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aer30iu_nDcht-uyYa4fwrhkKtYg1UHoks5ubBlbgaJpZM4WZ3We> .