Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5704: use untilAsserted to avoid early failure #2438

Merged
merged 2 commits into from Sep 7, 2018

Conversation

nonbinaryprogrammer
Copy link
Contributor

@nonbinaryprogrammer nonbinaryprogrammer commented Sep 7, 2018

There was an awaitility that intended to loop until data was consistent
but instead failed on the first pass if any keys weren't consistent.

Signed-off-by: khowe@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

There was an awaitility that intended to loop until data was consistent
but instead failed on the first pass if any keys weren't consistent.

Signed-off-by: khowe@pivotal.io
@nonbinaryprogrammer
Copy link
Contributor Author

Requesting review from @dhemery @mhansonp

}
} catch (Exception e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to catch and rethrow, as ThrowingRunnable throws Throwable. I think Awaitility will print the stack trace, too.

@nonbinaryprogrammer nonbinaryprogrammer merged commit 58eccef into apache:develop Sep 7, 2018
@nonbinaryprogrammer nonbinaryprogrammer deleted the GEODE-5704 branch September 7, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants