GEODE-5600 - Run createVersionPropertiesFile on SHA change

[rhoughton-pivot]

Found during testing, relating to GEODE-5694, remove the zip artifacts for better signing behavior

Authored-by: Robert Houghton rhoughton@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

[rhoughton-pivot]

@pivotal-jbarrett @smgoller @nabarunnag This changes the signing behavior a little bit, as relates to ZIP artifacts. Please check it out.

[PurelyApplied]

There are some remnants of the other changes in the previous attempt at GEODE-5600 that should be removed in favor of this approach. Notably:

• The properties sourceRevision and sourceRepository are not longer used in gradle.properties and should be removed.
• In the pull-request/jinja.template.yml, two instances of SOURCE_REPOSITORY no longer need to be passed to the test/build scripts.

[jake-at-work]

Asside from the changes that @PurelyApplied asked for I approve this change.

[PurelyApplied]

Spurious failure

> Task :geode-core:test

org.apache.geode.internal.process.lang.AvailablePidTest > findAvailablePidShouldNotReturnLivePid FAILED
    org.junit.runners.model.TestTimedOutException: test timed out after 20 seconds
        at java.nio.DirectByteBuffer.<init>(DirectByteBuffer.java:162)
        at sun.misc.Perf.attach(Native Method)
        at sun.misc.Perf.attachImpl(Perf.java:270)
        at sun.misc.Perf.attach(Perf.java:200)
        at sun.jvmstat.perfdata.monitor.protocol.local.PerfDataBuffer.<init>(PerfDataBuffer.java:64)
        at sun.jvmstat.perfdata.monitor.protocol.local.LocalMonitoredVm.<init>(LocalMonitoredVm.java:68)
        at sun.jvmstat.perfdata.monitor.protocol.local.MonitoredHostProvider.getMonitoredVm(MonitoredHostProvider.java:77)
        at sun.jvmstat.perfdata.monitor.protocol.local.MonitoredHostProvider.getMonitoredVm(MonitoredHostProvider.java:67)
        at sun.tools.attach.HotSpotAttachProvider.listVirtualMachines(HotSpotAttachProvider.java:101)
        at com.sun.tools.attach.VirtualMachine.list(VirtualMachine.java:147)
        at org.apache.geode.internal.process.AttachProcessUtils.isProcessAlive(AttachProcessUtils.java:35)
        at org.apache.geode.internal.process.ProcessUtils.isProcessAlive(ProcessUtils.java:81)
        at org.apache.geode.internal.process.lang.AvailablePidTest.findAvailablePidShouldNotReturnLivePid(AvailablePidTest.java:78)

passed upon rerun.

See failing:
https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/Build/builds/1057

vs passing:
https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/Build/builds/1063