Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5820: upgrade jetty to fix jetty tests in java10 #2567

Merged
merged 4 commits into from Oct 5, 2018

Conversation

jinmeiliao
Copy link
Member

Co-authored-by: Patrick Rhomberg prhomberg@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Co-authored-by: Patrick Rhomberg <prhomberg@pivotal.io>
Copy link
Member

@PurelyApplied PurelyApplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but I might not mention the java version in the commit message? While that might have been our original motivation, staying up-to-date in our tools has inherent value.

I dunno. Could go either way, really. +1 in any case.

@jinmeiliao
Copy link
Member Author

we can change it to java 9+

@jinmeiliao jinmeiliao merged commit db716cc into apache:develop Oct 5, 2018
@jinmeiliao jinmeiliao deleted the jetty branch October 5, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants