Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5811: Fix failing test on windows #2609

Merged

Conversation

jdeppe-pivotal
Copy link
Contributor

  • Convert to URL in the form file:/c:/foo/bar instead of file://c:/foo/bar

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

- Convert to URL in the form file:/c:/foo/bar instead of file://c:/foo/bar
@jdeppe-pivotal
Copy link
Contributor Author

Test failures look like this:

org.apache.geode.session.tests.Tomcat8Test > classMethod FAILED
    org.codehaus.cargo.container.ContainerException: Failed to download [file://C:/var/vcap/data/houdini-windows/containers/00000d2vhsi/tmp/build/5e0a0583/built-geode/test/geode-assembly/build/generated-resources/webservers/tomcat-8.5.34.zip]
        at org.codehaus.cargo.container.installer.ZipURLInstaller.download(ZipURLInstaller.java:456)
        at org.codehaus.cargo.container.installer.ZipURLInstaller.install(ZipURLInstaller.java:222)
        at org.apache.geode.session.tests.ContainerInstall.<init>(ContainerInstall.java:145)
        at org.apache.geode.session.tests.TomcatInstall.<init>(TomcatInstall.java:133)
        at org.apache.geode.session.tests.TomcatInstall.<init>(TomcatInstall.java:112)
        at org.apache.geode.session.tests.Tomcat8Test.setupTomcatInstall(Tomcat8Test.java:32)

        Caused by:
        java.net.UnknownHostException: C
            at org.apache.tools.ant.taskdefs.Get.execute(Get.java:82)
            at org.codehaus.cargo.container.installer.ZipURLInstaller.doDownload(ZipURLInstaller.java:498)
            at org.codehaus.cargo.container.installer.ZipURLInstaller.download(ZipURLInstaller.java:437)
            ... 5 more

@jdeppe-pivotal jdeppe-pivotal merged commit d5df61c into apache:develop Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants