GEODE-5897: change create jndi-binding to fail on an exception #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was caused by exception being caught, logged, and not rethrown. Now the gfsh function will get the thrown exception and pass a failure back to gfsh. For backwards compatibility, the XML parser still logs a warning if the jndi-binding can not be created, instead of having it cause the cache not to start.
when create jndi binding is done in gfsh or xml.
The function that implements create jndi-binding will now log an error if it fails. DataSourceCreateException now has a getWrappedException accessor.
dschneider-pivotal
requested review from
sboorlagadda,
jchen21,
kirklund and
agingade
sboorlagadda
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
👍 The change is important and required to make the gfsh command fails rather than asking users to go and logs files. But for cache xml we need to log and ignore the exception to retain existing behaviour.
If the data source cannot be bound to JNDI at runtime, GemFire logs a warning.
|
The one failure in integrationTest was a known issue (has a jira ticket) and was not related to this pr. |
kirklund
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create jndi-binding will now fail if an exception occurs during the create.
Also the data-source is now validated by asking it for a connection when the jndi-binding is created. If a connection can not be obtained, the create fails and the data-source is closed.
Previously if an exception occurred when creating a jndi-binding an info message was logged.
Now, as the docs state, a warning is logged.
@monkeyherder @BenjaminPerryRoss
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.