Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5819: fix ssl test failures in jdk11 #2702

Merged
merged 5 commits into from
Oct 25, 2018

Conversation

jinmeiliao
Copy link
Member

@jinmeiliao jinmeiliao commented Oct 24, 2018

  1. do not call getSession after startHandshake on a socket to make it TLS1.3 compliant
  2. when using TLS1.3 protocol in the tests, make sure to user a certificate that are TLS1.3 compliant.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@jinmeiliao jinmeiliao changed the title GEODE-5819: update the keystore used in ssl test to make it jdk11 com… GEODE-5819: fix ssl test failures in jdk11 Oct 24, 2018
@jinmeiliao jinmeiliao merged commit cfdd0a6 into apache:develop Oct 25, 2018
@jinmeiliao jinmeiliao deleted the wanTest branch October 25, 2018 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants