Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5819: Reduce 16h40m wait on shutdown to intended 60 seconds. #2736

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

PurelyApplied
Copy link
Member

  • While this is unlikely to correct the Java11 SSL handshake failures, it should make tests currently hanging properly fail out so that a full failure-set can be analyzed.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

* While this is unlikely to correct the Java11 SSL handshake failures, it should make tests currently hanging properly fail out so that a full failure-set can be analyzed.
@PurelyApplied
Copy link
Member Author

Upon some immediate look into the history, it looks like this was meant to be buffered out to something "longer than shutdown" but, I assume, not the 100x that it found. Maybe SHUTDOWN_WAIT_TIME * 2 would be sufficient? Any insight, @bschuchardt?

@bschuchardt
Copy link
Contributor

bschuchardt commented Oct 26, 2018

I'm thinking the extra 10000ms was meant to address that concern. Multiplying by two is probably fine given how big of an interval we've been using :-)

@PurelyApplied PurelyApplied merged commit 4e83d67 into apache:develop Oct 26, 2018
@PurelyApplied PurelyApplied deleted the geode-5819 branch January 9, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants