GEODE-5950 ensure images pick up new Java11 versions #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onichols-pivotal
force-pushed
the
GEODE-5950-automate-jdk11-updates
branch
from
371ba57
to
1053736
Compare
onichols-pivotal
force-pushed
the
GEODE-5950-automate-jdk11-updates
branch
from
1053736
to
a80008a
Compare
dickcav
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java 11.0.1 release exposed an oversight in the new pipeline: some triggers were not in place to ensure images were rebuilt with the new version.
With this fix, the linux image now grabs the latest released version of OpenJDK11 (instead of a hardcoded version), and both linux and windows images are triggered once a week (for lack of a better way to know when there is a new chocolatey update for windows or a change to download link for linux).
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
[n/a] Does
gradlew buildrun cleanly?[n/a] Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?