Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5977: rename --connection to --data-source #2773

Merged
merged 5 commits into from Nov 6, 2018

Conversation

dschneider-pivotal
Copy link
Contributor

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@davebarnes97
Copy link
Contributor

davebarnes97 commented Nov 5, 2018

A few comments/questions:

  • I added a 'docs' component to the JIRA ticket (GEODE-5977) because docs are affected by this change.
  • For the gfsh command create jdbc-mapping, the --connection option is being deleted entirely in favor of data-source. Does this constitute a 'breaking change'?

@dschneider-pivotal
Copy link
Contributor Author

@davebarnes97 create jdbc-mapping is experimental so it can be changed in a way that is not backwards compatible.

@dschneider-pivotal dschneider-pivotal merged commit 72a5b0b into develop Nov 6, 2018
@dschneider-pivotal dschneider-pivotal deleted the feature/GEODE-5977 branch November 6, 2018 20:00
upthewaterspout pushed a commit to upthewaterspout/geode that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants