GEODE-5884: Adding to function exception list if matching cause #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuynh1
force-pushed
the
feature/GEODE-5884
branch
from
ab49d59
to
249d868
Compare
mcmellawatt
reviewed
Nov 8, 2018
| @@ -378,6 +379,22 @@ public ExecuteRegionFunctionOpImpl(String region, Function function, | |||
| this.isHA = function.isHA(); | |||
| } | |||
|
|
|||
| // For testing only | |||
| ExecuteRegionFunctionOpImpl() { | |||
There was a problem hiding this comment.
Is there a way to test this without adding a new test hook to product code?
There was a problem hiding this comment.
I think the problem is that the product wasn't quite testable in the first place. Yes we can mock around and use the existing constructors, but I think effort is better spent refactoring the class itself instead of munging tests.
There was a problem hiding this comment.
I'll work on the refactoring as a separate commit. I think I'll modify the existing constructors (and new tests) to use a new constructor that assigns the final variables.
jhuynh1
force-pushed
the
feature/GEODE-5884
branch
from
249d868
to
fde9a52
Compare
…ocationTargetException
mcmellawatt
pushed a commit
that referenced
this pull request
Nov 16, 2018
…ocationTargetException (#2809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is FunctionInvocationTargetException
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.