Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEODE-6021] Introduce Lombok #2815

Closed
wants to merge 1 commit into from

Conversation

aditya87
Copy link
Contributor

@aditya87 aditya87 commented Nov 8, 2018

Signed-off-by: Peter Tran ptran@pivotal.io

Wanted to introduce Lombok (https://projectlombok.org/) as proof-of-concept of how it can reduce the size of some classes.

We see the following advantages of using Lombok:
-> Less boilerplate code.
-> Can use builder pattern implicitly, which allows for much better composeability of an object.
-> Increased readability

More details: https://projectlombok.org/features/all

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@metatype
Copy link
Contributor

metatype commented Nov 8, 2018

@aditya87 Can you poke the dev@ list with this proposed change? I think it's a big enough change to warrant discussion.

@aditya87 aditya87 changed the title Introduce Lombok [GEODE-6021] Introduce Lombok Nov 8, 2018
Signed-off-by: Peter Tran <ptran@pivotal.io>
@aditya87
Copy link
Contributor Author

aditya87 commented Nov 9, 2018

Withdrawing for now. There are some risks associated with JDK10 that we need to investigate further. Further discussion on the geode-dev list.

@aditya87 aditya87 closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants