GEODE-5993: Eliminate race in monitorQueryThread() #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuynh1
approved these changes
Nov 9, 2018
jhuynh1
reviewed
Nov 9, 2018
A race existed between setting low memory in the heap monitor thread, and checking the low memory state in query monitoring thread. The cancelation executor was shut down and no longer accepting new tasks when this race occurred, causing a RejectedExecutionException. This commit solves that problem by encapsulating the scheduling behavior using the state design pattern. Co-authored-by: Ryan McMahon <rmcmahon@pivotal.io> Co-authored-by: Bill Burcham <bburcham@pivotal.io>
Bill
force-pushed
the
feature/GEODE-5993
branch
from
9c313b4
to
b1a8ca8
Compare
|
DUnit tests passed in previous run except for a known issue. Integration tests failed in previous run due to global problem (on Rerunning tests now with the goal of seeing integration tests pass 💚 |
mcmellawatt
added a commit
to mcmellawatt/geode
that referenced
this pull request
Nov 15, 2018
A race existed between setting low memory in the heap monitor thread, and checking the low memory state in query monitoring thread. The cancelation executor was shut down and no longer accepting new tasks when this race occurred, causing a RejectedExecutionException. This commit solves that problem by encapsulating the scheduling behavior using the state design pattern. Co-authored-by: Ryan McMahon <rmcmahon@pivotal.io> Co-authored-by: Bill Burcham <bburcham@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race existed between setting low memory in the heap monitor thread,
and checking the low memory state in query monitoring thread.
The cancelation executor was shut down and no longer accepting new
tasks when this race occurred, causing a RejectedExecutionException.
This commit solves that problem by encapsulating the scheduling
behavior using the state design pattern.
Co-authored-by: Ryan McMahon rmcmahon@pivotal.io
Co-authored-by: Bill Burcham bburcham@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.