Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved cleanup for UITests #284

Closed
wants to merge 1 commit into from
Closed

Improved cleanup for UITests #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 13 additions & 8 deletions geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseAbstractTest.java
View file
Open in desktop
Expand Up @@ -224,8 +224,18 @@ private static void setUpWebDriver() {

@AfterClass
public static void tearDownAfterClass() throws Exception {
driver.close();
jetty.stop();
if (driver != null) {
driver.close();
driver = null;
}
if (jetty != null) {
jetty.stop();
jetty = null;
}
if (server != null) {
server.stop();
server = null;
}
}

@Before
Expand Down Expand Up @@ -402,10 +412,7 @@ public void testClusterQuerRequestRateWidget() {
@Test
public void testClusterGridViewMemberID() throws InterruptedException {
searchByIdAndClick("default_grid_button");
List<WebElement> elements = driver.findElements(By.xpath("//table[@id='memberList']/tbody/tr")); // gives
// me
// 11
// rows
List<WebElement> elements = driver.findElements(By.xpath("//table[@id='memberList']/tbody/tr"));

for (int memberCount = 1; memberCount < elements.size(); memberCount++) {
String memberId = driver
Expand Down Expand Up @@ -932,7 +939,6 @@ public void testTreeMapPopUpData(String S1, String gridIcon) {
String loadAvgM1 = JMXProperties.getInstance().getProperty("member.M" + (i) + ".loadAverage");
assertEquals(df2.format(Double.valueOf(loadAvgM1)), LoadAvgM1);


String ThreadsM1 = driver
.findElement(
By.xpath("//div[@id='_tooltip']/div/div/div[2]/div[" + (j + 3) + "]/div[2]/div"))
Expand Down Expand Up @@ -1035,7 +1041,6 @@ public void testDataBrowser() {
wait.until(ExpectedConditions
.visibilityOf(driver.findElement(By.xpath("//label[text()='Data Browser']"))));


// Verify all elements must be displayed on data browser screen
assertTrue(driver.findElement(By.xpath("//a[text()='Data Regions']")).isDisplayed());
assertTrue(driver.findElement(By.id("linkColocatedRegions")).isDisplayed());
Expand Down