GEODE-6260: Do not cleanup non-dirty entries in transactional set operation #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-eshu
requested review from
kirklund,
agingade,
lgallinat and
dschneider-pivotal
| @@ -1540,6 +1540,11 @@ protected TXEntryState txReadEntry(KeyInfo keyInfo, InternalRegion internalRegio | |||
| txr = txWriteRegion(internalRegion, keyInfo); | |||
| } | |||
| result = dataReg.createReadEntry(txr, keyInfo, createIfAbsent); | |||
| if (result == null) { | |||
| assert !createIfAbsent; | |||
There was a problem hiding this comment.
Does "!createIfAbsent" indicate that this is a set operation? If so I think you should add a comment here.
Something like "createReadEntry will only returns null if createIfAbsent is false. CreateIfAbsent will only be false when this method is called by set operations. In that case we do not want the TXState to have a TXEntryState."
There was a problem hiding this comment.
Will make the changes by using the more descriptive comments.
dschneider-pivotal
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.