GEODE-6232: Extract ResourceEventNotifier from InternalDistributedSystem #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to wait for PR #3087 to be merged in. |
kirklund
force-pushed
the
GEODE-6232-refactor-ResourceEventNotifier-PR
branch
from
3c65b59
to
c04259d
Compare
|
This branch seems to reintroduce GEODE-6285 in some way. |
Extract ResourceEventNotifier from InternalDistributedSystem. Inject ResourceEventNotifier via constructor into most of the classes that need it.
kirklund
force-pushed
the
GEODE-6232-refactor-ResourceEventNotifier-PR
branch
from
3b05342
to
62a6dc5
Compare
|
@galen-pivotal At this point of continued test failures with no clear cause, I create a new branch and repeat the refactoring in smaller steps that each go through precheckin. I'm going to close the PR and plan to go in that direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not fix GEODE-6232 but is a necessary step in delivering the fix.
Please review @demery-pivotal @mhansonp