Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-6280: Create new public module for the Management API #3083

Merged
merged 1 commit into from Jan 23, 2019
Merged

GEODE-6280: Create new public module for the Management API #3083

merged 1 commit into from Jan 23, 2019

Conversation

jdeppe-pivotal
Copy link
Contributor

@jdeppe-pivotal jdeppe-pivotal commented Jan 16, 2019 •
edited

  • This moves the classes under org.apache.geode.cache.configuration classes into a public module: geode-managament-api. The intent is that this module will have no dependencies to geode-core but will allow consumers to perform administration tasks (creating regions, etc.).
  • geode-core will now depend on both geode-management-api as well as geode-common (transitively). Suggestions on how to improve these new dependencies are welcome.

Signed-off-by: Peter Tran ptran@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@jdeppe-pivotal
Copy link
Contributor Author

@aditya87 - for your review

@aditya87 aditya87 force-pushed the feature/GEODE-6280 branch 2 times, most recently from 8214a64 to ce5dbce Compare January 22, 2019 22:32
@jdeppe-pivotal
GEODE-6280: Create new public module for the Management API
7916389 
- This moves the classes under `org.apache.geode.cache.configuration` package
  into a public module: `geode-managament-api`. The intent is that this module
  will have no dependencies to `geode-core` but will allow consumers to perform
  administration tasks (creating regions, etc.).
- `geode-core` will now depend on both `geode-management-api` as well as
  `geode-common` (transitively). Suggestions on how to improve these new
  dependencies are welcome.

Signed-off-by: Peter Tran <ptran@pivotal.io>
Signed-off-by: Aditya Anchuri <aanchuri@pivotal.io>
@jdeppe-pivotal jdeppe-pivotal merged commit 9bb8579 into apache:develop Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohlmu-pivotal kohlmu-pivotal kohlmu-pivotal approved these changes

@jinmeiliao jinmeiliao jinmeiliao approved these changes

@metatype metatype Awaiting requested review from metatype

@pdxrunner pdxrunner Awaiting requested review from pdxrunner

@jake-at-work jake-at-work Awaiting requested review from jake-at-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jdeppe-pivotal @kohlmu-pivotal @jinmeiliao