Feature/geode 6244b - review not required #3093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not allow membership manager suspect initiation to kick out a
member on the first failed check
- perform a self-health check before sending SuspectRequest messages
- consider members who have sent shutdown messages as gone when
performing "should I become coordinator" checks in GMSHealthMonitor
- modified the membership view installed by GMSJoinLeave to be immutable
so it isn't inadvertently changes
Squashed commit of the following:
commit 44f37c38d3b42f1ec7b1c440cae234b3fc123955
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Thu Jan 17 14:28:25 2019 -0800
fixes for regression failures
commit 320e98f
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Fri Jan 4 14:42:03 2019 -0800
fix for failing unit tests & a lgtm warning
commit 144f943
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Fri Jan 4 10:36:22 2019 -0800
fixes for unit test hang
- remove suspect from members-in-final-check collection and initiate
both remote and local suspect processing
- renamed "final check" to "availability check" since it isn't
necessarily a "final" check
- perform a self-check before telling others to check a suspect
commit fb3dfd0
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Thu Jan 3 14:22:51 2019 -0800
leave the member unsuspected after final check fails
If the final check fails and we're not going to remove the suspect from
the distributed system we need to leave it in an "unsuspected" state
locally so that the background monitoring thread will look at it again.
Also, if the final check failed in the membership coordinator there's no
point in doing another check so we move directly to removing the
suspect.
commit 25134b1
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Thu Jan 3 12:49:56 2019 -0800
GEODE-6244 Healthy member kicked out by Sick member
GMSMembershipManager.verifyMember() should not initiate direct removal
of the target member if an availability check fails. Instead it should
initiate suspect processing.
This adds new unit tests for GMSHealthMonitor.checkIfAvailable() and
changes the availability check to initiate suspect processing if the
check fails.
(cherry picked from commit f4b8cf2)
bschuchardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.