GEODE-6174: change refid to type and make the default type to be PART…

[jinmeiliao]

…ITION

Co-authored-by: Peter Tran ptran@pivotal.io

• change refid to type for better UX
• add a common config validator interface and use that to validate RegionConfig

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

[jinmeiliao]

@onichols-pivotal @Petahhh

[onichols-pivotal]

Looks good and all tests are passing. Do we need any additional tests here to cover empty strings or whitespace strings (vs missing region name entirely)? Do we need additional tests to cover invalid region types? What about empty or whitespace region types, are those error or default to PARTITIONED? Do we need any tests here of region names containing punctuation or weird characters or newlines?

[jinmeiliao]

thanks! there is validation on the invalid region types. As to invalid region names, we should have a story to cover that. I've mentioned this to @aditya87 before, but he prefer not to include it just yet.