GEODE-6174: more error handling in LocatorClusterConfigurationService #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fail early if cluster persistence serivce is not enabled * creating the region twice will result in status code 409 * if region creation is partially failed on members, do not update cluster configuration.
jdeppe-pivotal
requested changes
Jan 30, 2019
| @@ -79,6 +79,7 @@ public void createsRegion() throws Exception { | |||
|
|
|||
| @Test | |||
| public void createsAPartitionedRegionByDefault() throws Exception { | |||
| IgnoredException.addIgnoredException("cache element orders already exists."); | |||
There was a problem hiding this comment.
We should not be dumping exceptions like this into the log. We should not even need to log anything.
| "successfully persisted config for " + finalGroup); | ||
| } catch (Exception e) { | ||
| String message = "failed to update cluster config for " + finalGroup; | ||
| logger.error(message, e); |
There was a problem hiding this comment.
Ditto my comment about logging exceptions from above. This can be removed.
There was a problem hiding this comment.
we are catching an exception here, if we don't log here, we might lose the stack trace.
There was a problem hiding this comment.
Oh right. Sorry, I thought this was the cause of the IgnoredException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.