Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-6174: move exists method into the validator #3217

Merged
merged 2 commits into from Feb 21, 2019

Conversation

jinmeiliao
Copy link
Member

Co-authored-by: Kenneth Howe khowe@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Co-authored-by: Kenneth Howe <khowe@pivotal.io>
@jinmeiliao
Copy link
Member Author

@Petahhh @onichols-pivotal

@pdxrunner
Copy link

This provides a better division of responsibilities between the validator and mutator. Validator calls occur before the Config object is "realized" through the distributed function call to the servers. The Mutator handles persistence of the configuration after "realization".

Co-authored-by: Kenneth Howe <khowe@pivotal.io>

* add invalid region name validation
@jinmeiliao jinmeiliao merged commit bc3743e into apache:develop Feb 21, 2019
@jinmeiliao jinmeiliao deleted the validation branch February 21, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants