GEODE-6443: log all request and response in geode management service #3373
Conversation
| } | ||
| String payload = getContentAsString(wrappedRequest.getContentAsByteArray(), | ||
| wrappedRequest.getCharacterEncoding()); | ||
| logger.info(String.format(requestPattern, request.getMethod(), requestUrl, |
There was a problem hiding this comment.
The request should be logged before the filterChain.doFilter call - that way any logged errors will appear after the request in the log and the sequence of events will be correct.
There was a problem hiding this comment.
before the filter call, the payload information is not available.
| String responsePattern = "Management Response: Status=%s; response=%s"; | ||
| payload = getContentAsString(wrappedResponse.getContentAsByteArray(), | ||
| wrappedResponse.getCharacterEncoding()); | ||
| logger.info(String.format(responsePattern, response.getStatus(), payload)); |
There was a problem hiding this comment.
I see this payload ends up with a bunch of newlines. Can you strip those out so we only log a single message line? Having multiple log lines (for a single entry) will mess up any log scraping that someone might do.
| @@ -64,14 +61,8 @@ public void checkRequestsAreLogged() throws Exception { | |||
| RegionConfig regionConfig = new RegionConfig(); | |||
There was a problem hiding this comment.
Can you add a start for the appender otherwise it ends up with some weird ERROR lines in the log - I thought I had done that when I originally wrote this, but I guess not.
|
flaky test failure not related to this PR |
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.